[PATCH 0/6] various FSCTL_SET_SPARSE tests and a bug fix

David Disseldorp ddiss at samba.org
Wed Aug 27 07:41:56 MDT 2014

This patch-set adds a number of tests for FSCTL_SET_SPARSE to:
- Check that the sparse attribute is retained / cleared according to
  MS-FSCC specs, with and without a SetSparse buffer.
- Confirm that the FSCTL fails with STATUS_INVALID_PARAMETER when
  requested with a directory handle.
	- This was broken on Samba (bso#10787). A fix is included.

The added tests are currently skipped against (unmodified) Samba, as it
doesn't advertise the FILE_SUPPORTS_SPARSE_FILES capability flag.

Feedback appreciated.


The following changes since commit 4383ec5b83d12bd19749582217f082cbaa31a128:

  s4:setup/dns_update_list: make use of the new substitution variables (2014-08-26 11:38:54 +0200)

are available in the git repository at:

  git://git.samba.org/ddiss/samba.git sparse

for you to fetch changes up to 4f3432b37b4f11d8d918c3bb9856d33d9f649910:

  torture: trivial test_ioctl_network_interface_info cleanup (2014-08-27 15:20:08 +0200)

David Disseldorp (6):
      idl: define sparse file fsctl structures
      torture: test FSCTL_SET_SPARSE
      torture: test FSCTL_SET_SPARSE against a directory
      dosmode: fix FSCTL_SET_SPARSE request validation
      torture: test FSCTL_SET_SPARSE without SetSparse buffer
      torture: trivial test_ioctl_network_interface_info cleanup

 librpc/idl/ioctl.idl         |  35 ++++++++++++++++++
 source3/smbd/dosmode.c       |  13 +++++++
 source4/torture/smb2/ioctl.c | 279 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 3 files changed, 322 insertions(+), 5 deletions(-)

More information about the samba-technical mailing list