[PATCH] DNS and Subdomain patches

Andrew Bartlett abartlet at samba.org
Tue Aug 26 16:28:44 MDT 2014

On Tue, 2014-08-26 at 18:25 +0200, Stefan (metze) Metzmacher wrote:
> Am 26.08.2014 um 06:10 schrieb Andrew Bartlett:
> > I've done a successful autobuild of the DNS and subdomain patch set in
> > my metze-master4-dns branch, and confirmed manually that when combined
> > into my subdomain-wip branch, than it all works for a subdomain join
> > against windows.
> > 
> > The combined 'ready for master' patches are all at
> > 
> > http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/metze-master4-dns
> > 
> > Some are tagged TODO just looking for a re-review after the requested
> > fixes.
> > 
> > Metze,
> > 
> > I've reviewed your changes and just need to remove some TODO markers on
> > for review tags. 
> I've pushed the dns related changes expect of the dlz_bind9 changes,
> for those I expected you test and fixed a few bugs:

I tested lookups and adding a new name using nsupdate -g.  Is there
anything else specific you were looking for?  I'm assuming we got into
trouble with multi-valued records?

> I think the attached patches are ready for master now.

This looks impressive!  Thank you so much for running with the pattern,
we now have much, much better coverage here, and this also really helps
the internal DNS server, given how much is now shared.

However, one concern I have is that you force the client to use the
dns-server account.  This is incorrect, the client should use
DNS/server.domain, via set_target_hostname and set_target_service.  This
will additionally verify that we have the correct SPN mapping.

I'm going to try and fix that up, and re-propose the branch. 

> The rest (your patches) are updated in the following branch:
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-abartlet4


> Here's a new question:
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=7b9fe2b3e49f97440c8e1a1a55436bb6efb6bd0c

Thanks, I'll fix that up per jelmer's reply. 

> I added:
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=23781a841ad39d756ebab95b01235242436b6b90

Thanks, that looks better.

> > Jelmer, I've applied your review tags, a couple just need to be
> > double-checked.
> The other TODO REVIEW commits are to be verified by Jelmer.

Once we get those fixed, are we able to get those in?


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list