[PATCH] DNS and Subdomain patches

[Jelmer Vernooij]

On Tue, Aug 26, 2014 at 11:18:16PM +0200, Jelmer Vernooij wrote:
> On Tue, Aug 26, 2014 at 04:10:12PM +1200, Andrew Bartlett wrote:
> > I've done a successful autobuild of the DNS and subdomain patch set in
> > my metze-master4-dns branch, and confirmed manually that when combined
> > into my subdomain-wip branch, than it all works for a subdomain join
> > against windows.
> > 
> > The combined 'ready for master' patches are all at
> > 
> > http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/metze-master4-dns
> > 
> > Some are tagged TODO just looking for a re-review after the requested
> > fixes.
> > 
> > Metze,
> > 
> > I've reviewed your changes and just need to remove some TODO markers on
> > for review tags. 
> > 
> > Jelmer, I've applied your review tags, a couple just need to be
> > double-checked.
> 
> The 5 tagged with TODO (change ids:
> I3787f4f3433ca04628f888135c7c0c8195379542,
> I1266f77184d68aae6a39a73bac8a432fdd707b2e,
> I9aa32c5692cd9fd0a6bced8bea37cd8593b31906,
> I008af94a0822012c211cfcc6108a8b1285f4d7c7,
> I41ac256fb3d4edffc617af4ae580acd941b4de83) now look good to me. Reviewed-By: Jelmer
> Vernooij <jelmer at samba.org>

As discussed on IRC, in I9aa32c5692cd9fd0a6bced8bea37cd8593b31906 you
want:

del partfile[domainzonedn]
del partfile[forestzonedn]

rather than:

del domainzone_file
del forestzone_file

With those two modifications, my R-B still stands :)

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - https://jelmer.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140826/53a24a5a/attachment.pgp>