[PATCH 22/22] winbindd: make a connection to our internal AD server to fill in domain->active_directory

[Jelmer Vernooij]

On Wed, Aug 20, 2014 at 02:06:57PM +1200, abartlet at samba.org wrote:
> From: Andrew Bartlett <abartlet at samba.org>
> 
> Change-Id: Ic9f2e5b6be5fcaf5f7e99580fdb5b144dd0c1234
> Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> ---
>  source3/winbindd/winbindd_cm.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
> index bef0114..53df54f 100644
> --- a/source3/winbindd/winbindd_cm.c
> +++ b/source3/winbindd/winbindd_cm.c
> @@ -2021,22 +2021,24 @@ static bool set_dc_type_and_flags_trustinfo( struct winbindd_domain *domain )
>  	}
>  
>  	our_domain = find_our_domain();
> -	result = init_dc_connection(our_domain, false);
> -	
> -	if (!NT_STATUS_IS_OK(result)) {
> -		DEBUG(3,("set_dc_type_and_flags_trustinfo: Not able to make a connection to our domain: %s\n",
> -			 nt_errstr(result)));
> -		return False;
> +
> +	mem_ctx = talloc_stackframe();
> +
> +	if (our_domain->internal) {
> +		result = init_dc_connection(our_domain, false);
> +		
> +		if (!NT_STATUS_IS_OK(result)) {
> +			DEBUG(3,("set_dc_type_and_flags_trustinfo: Not able to make a connection to our domain: %s\n",
> +				 nt_errstr(result)));
> +			return False;
s/False/false/

Long lines?

Otherwise:

Reviewed-By: Jelmer Vernooij <jelmer at samba.org>

-- 
Jelmer Vernooij <jelmer at samba.org> - https://jelmer.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140825/c8a3c0fd/attachment.pgp>