[PATCH 13/22] dsdb: Make log message more clear
Jelmer Vernooij
jelmer at samba.org
Mon Aug 25 09:49:56 MDT 2014
On Wed, Aug 20, 2014 at 02:06:48PM +1200, abartlet at samba.org wrote:
> From: Andrew Bartlett <abartlet at samba.org>
>
> Change-Id: Ibf3c55748e755d2f6dae57293bfde11cdf7ba3ae
> Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> ---
> source4/dsdb/common/util.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
> index 18f16f6..0cd0999 100644
> --- a/source4/dsdb/common/util.c
> +++ b/source4/dsdb/common/util.c
> @@ -4285,8 +4285,10 @@ int dsdb_validate_dsa_guid(struct ldb_context *ldb,
>
> account_dn = ldb_msg_find_attr_as_dn(ldb, tmp_ctx, msg, "serverReference");
> if (account_dn == NULL) {
> - DEBUG(1,(__location__ ": Failed to find account_dn for DSA with objectGUID %s, sid %s\n",
> - GUID_string(tmp_ctx, dsa_guid), dom_sid_string(tmp_ctx, sid)));
> + DEBUG(1,(__location__ ": Failed to find account dn (serverReference) for %s, parent of DSA with objectGUID %s, sid %s\n",
This line looks like it's over the limit in our style guide. Please
split.
Otherwise:
Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
--
Jelmer Vernooij <jelmer at samba.org> - https://jelmer.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140825/c50adca4/attachment.pgp>
More information about the samba-technical
mailing list