[PATCH] Subdomain and trusted domain patches for master

[Stefan (metze) Metzmacher]

Hi Andrew,

the mayor thing I'm missing in your patches is the usage of
Correct 'domainsid' in source4/dsdb/samdb/ldb_modules/descriptor.c
get_sd_unpacked().

For the Applications partitions (dns) there's a msDS-SDReferenceDomain
attribute on the crossRef object.

metze

Am 20.08.2014 um 16:02 schrieb Andreas Schneider:
> On Wednesday 20 August 2014 13:41:06 Andrew Bartlett wrote:
>> G'Day,
> 
> Hi,
>  
>> I've been working to bring subdomain and trusted domain support to Samba
>> GIT master.
>>
>> I think these changes are ready for master, and so I would like them
>> reviewed and pushed:
>> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/subd
>> omain-for-master
>>
>> This will reduce the set of patches in my WIP tree here:
>> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/subd
>> omain-wip
> 
> I've started to review your patches.
> 
> 
> Andrew, if you are a vim user, I suggest to add the following lines to your 
> vim config:
> 
> 
> " Highlight long lines
> autocmd BufWinEnter *.c,*.h let w:m2=matchadd('ErrorMsg', '\%>80v.\+', -1)
> 
> " Show tabs and trailing whitespace visually
> if (&termencoding == "utf-8") || has("gui_running")
>     if v:version >= 700
>         set list listchars=tab:»·,trail:·,extends:…,nbsp:‗
>     else
>         set list listchars=tab:»·,trail:·,extends:…
>     endif
> else
>     if v:version >= 700
>         set list listchars=tab:>-,trail:.,extends:>,nbsp:_
>     else
>         set list listchars=tab:>-,trail:.,extends:>
>     endif
> endif
> 
> 
> This will show you if a line exceeds 80 chars and you can visually see tabs 
> and trailing spaces!!! ;)
> 
> 
> 
> Cheers,
> 
> 	-- andreas
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140820/ce3cce80/attachment.pgp>