[PATCH] replace: Remove unused item returned by FAILED()

Amitay Isaacs amitay at gmail.com
Wed Aug 20 06:31:09 MDT 2014


On Tue, Aug 12, 2014 at 7:29 PM, Martin Schwenke <martin at meltin.net> wrote:

> The (return) value of FAILED() is a constant 1.  However, it is never
> used, so the compiler complains when run with -Wall:
>
>   lib/replace/test/os2_delete.c: In function ‘cleanup’:
>   lib/replace/test/os2_delete.c:39:163: warning: right-hand operand of
> comma expression has no effect [-Wunused-value]
>    FAILED("system");
>
> So just get remove the ", 1" since it is the bit that does nothing and
> is never used.
>
> peace & happiness,
> martin
>

Pushed.

Amitay.


More information about the samba-technical mailing list