[PATCHES] Fix/avoid compiler warnings in CTDB
Amitay Isaacs
amitay at gmail.com
Wed Aug 20 06:26:36 MDT 2014
On Tue, Aug 12, 2014 at 7:43 PM, Martin Schwenke <martin at meltin.net> wrote:
> The only possibly controversial thing here might be:
>
> [PATCH 1/5] ctdb-common: Copy functions sys_read() and sys_write()
> from source3
>
> We really should extricate these from source3 and into some common
> code. However, just copy them for now to help get rid of a lot of
> warnings.
>
> It would probably be easy to get these functions out of source3 and
> into the top-level Samba lib/util. However, removing CTDB's own
> lib/util so that we can use the top-level Samba one is non-trivial -
> I've started working on that. So, to finally fix the code and get rid
> of warnings now, this seems like a good idea.
>
> Please review and push if OK.
>
> These and the other patches from my 4 most recent posts are in my ctdb
> branch:
>
> http://git.samba.org/?p=martins/samba.git;a=shortlog;h=refs/heads/ctdb
>
> peace & happiness,
> martin
>
Minor issue in the third patch. Library call system() call does not set
errno. So instead log the command that failed.
Amitay.
More information about the samba-technical
mailing list