Padding byte in cifs readx response

Jeremy Allison jra at samba.org
Fri Aug 15 11:17:15 MDT 2014


On Thu, Aug 14, 2014 at 10:30:52PM -0700, Christof Schmitt wrote:
> On Wed, Aug 13, 2014 at 04:10:34PM +0200, Volker Lendecke wrote:
> > We just overflowed the 16MB nbss packet. I've attached one
> > question, a few R-Bs and a possible fix.
> 
> Thanks. The fix looks good, i included it in the patch series, see
> attachment.
> > 
> > VL: I think at least in the aio case the padding byte is left uninitialized.
> > Can you check that? Thanks!
> 
> Yes, i missed that. struct aio_extra is allocated and zeroed, but not
> the following data buffer. I added the explicit initialization of the
> padding byte.

LGTM Christof thanks ! Pushed.

Do you want to log a bug so we can get this into at least 4.1.next ?

Cheers,

	Jeremy.


More information about the samba-technical mailing list