Removing the original params.c parser (was: Re: [PATCH] lib: Remove some unused code)
Volker.Lendecke at SerNet.DE
Fri Aug 15 07:16:53 MDT 2014
On Fri, Aug 15, 2014 at 02:24:20PM +0200, David Disseldorp wrote:
> On Fri, 15 Aug 2014 11:34:13 +0200, Volker Lendecke wrote:
> > > If this hurts feelings to much, I take back the push
> > > request. If I have to write apologies for every - I have in
> > > a diff in the future, this will really, really become
> > > difficult to code for.
> Nobody was asking for an apology. I think Andrew was just requesting
Well, Andrew has not explicitly asked for an apology, but the text he
proposes really does sound like one. I will not apologize for removal
of code. I tried to start to gradually move it towards something more
in line with what current Samba code would look like, but Chris NACKed
that right away as well, so params.c is just around to stay forever.
tini.c is used in the iniparser replacement, so it does get its
use. Please push the revert. It is a hack of a few hours during a meeting,
it is not worth any argument.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical