[PATCH][CIFS] Workaround MacOS server problem with SMB2.1 write response

Jeremy Allison jra at samba.org
Thu Aug 14 14:44:24 MDT 2014

On Thu, Aug 14, 2014 at 04:40:14PM -0400, Jeff Layton wrote:
> Failing here won't change the buffer allocation. That buffer has
> already been allocated, and the receive is complete at this point. So
> any "damage" has already been done.

Yep. You've got to have read the data to know it's too much !

> So, I just don't get why you'd bother with an arbitrary limit at all.
> The error checking is _simpler_ if you don't bother with this limit. Or
> am I missing something here?

Nope. The server has to deal with the same problem
as well. We just accept what the client sends inside
the NetBIOS length limit, and ignore anything after
the "useful" data within the packet.

Doesn't matter *what* is in the extra bits, code
data, whatever. We don't look at it.

Steve, what is the problem with just ignoring the
extra data ? If it offends you - log a warning
message is the rfc1001 length is too long and
ignore it.

More information about the samba-technical mailing list