[PATCH v6] New VFS module vfs_fruit
Jeremy Allison
jra at samba.org
Wed Aug 13 12:19:45 MDT 2014
On Wed, Aug 13, 2014 at 12:10:25PM +0200, Ralph Böhme wrote:
>
> $ make test TESTS=fruit
>
> catched a double talloc_free(), with this patch
>
> --- a/source3/modules/vfs_fruit.c
> +++ b/source3/modules/vfs_fruit.c
> @@ -1696,7 +1696,6 @@ static int fruit_connect(vfs_handle_struct *handle,
> }
>
> TALLOC_FREE(list);
> - TALLOC_FREE(newlist);
>
> rc = init_fruit_config(handle);
> if (rc != 0) {
>
> it all looks good.
Perfect catch - thanks ! I missed the
fact that newlist was alloced off the list
context.
> Updated patch attached.
OK - LGTM with my Reviewed-by:
Now the $20,000 question - can we get
a second Team reviewer please ? :-) :-).
Cheers,
Jeremy.
More information about the samba-technical
mailing list