[PATCH] ctdb-daemon: Fork lock helper with vfork_with_logging()

Amitay Isaacs amitay at gmail.com
Tue Aug 12 19:51:44 MDT 2014


On Tue, Aug 12, 2014 at 7:23 PM, Martin Schwenke <martin at meltin.net> wrote:

> Otherwise errors printed by the lock helper get lost.
>
> * lock_helper_args() no longer adds the program name to the list of
>   arguments, since vfork_with_logging() does that.
>
> * Update the lock helper to handle the extra log_fd parameter and send
>   stdout/stderr there.
>
> * For simplicity, add an argc parameter to lock_helper_args().  To
>   make this sane, also add an argv parameter and change the return
>   type to bool.
>
> Please review and push if OK.
>
>
Too many changes in one patch.  It might be better to split the argc/argv
changes into a separate patch.

Amitay.


More information about the samba-technical mailing list