[PATCH] lib: Fix whitespace in params.c
Christopher R. Hertel
crh at samba.org
Mon Aug 11 06:31:11 MDT 2014
On 08/11/2014 05:47 AM, Volker Lendecke wrote:
> Review&push would be appreciated.
If you are going to change the formatting style of a file, run it through
indent and change the whole thing to match the project "standard".
Also, this isn't a "fix", it's just a change. (This isn't a bug, it's a
preference.) The formatting style in this particular file is known as
"whitesmith", and it was once quite popular. I know, because it's my coding
style. I also know that I haven't touched that file since I rewrote it for
Samba 2 more than 10 years ago.
So, my vote is to either leave it as is or to completely convert it to the
current preferred formatting style.
"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/ -)----- Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/ -)----- ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/ -)----- crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/ -)----- crh at ubiqx.org
More information about the samba-technical