RC2 for third_party.

['Jelmer Vernooij']

On Sun, Aug 10, 2014 at 08:51:37AM +0200, Andreas Schneider wrote:
> On Saturday 09 August 2014 17:11:29 Jeremy Allison wrote:
> > On Fri, Aug 08, 2014 at 11:29:48AM -0700, Jeremy Allison wrote:
> > > On Thu, Aug 07, 2014 at 09:49:08PM -0400, Ira Cooper wrote:
> > > > I've updated third_party to deal with the issues that were pointed out
> > > > in
> > > > the last review.
> > > > 
> > > > The libraries are still removed at the end, as in previous versions.
> > > > 
> > > > I look forward to your reviews.
> > > > 
> > > > http://git.samba.org/?p=ira/wip.git;a=shortlog;h=refs/heads/third_party
> > > 
> > > There are a few whitespace errors which need fixing, but
> > > other than that you have my 'Reviewed-by:' up to the
> > > last patch which removes the toplevel third_party/ lib.
> > > 
> > > There's a problem with that, unfortunately (much though
> > > this is causing my to gnash my teeth, as that's the bit
> > > I really wanted).
> > > 
> > > Debian / Ubuntu doesn't package iniparser-dev :-). Or
> > > indeed initparser at all :-).
> > > 
> > > Fedora does, but the attitude of the Debian devs is
> > > that iniparser is the spawn of the devil, and should
> > > never be packaged for Debian.
> > > 
> > > Looking at the iniparser code, it's hard to argue :-).
> > > 
> > > So I'll take it upon myself to remove the iniparse
> > > code from Samba, and replace it with something that
> > > will do the job instead and is appropriately licensed
> > > for libraries that need to link with proprietary code.
> > 
> > So there isn't a really good easy iniparser replacement
> > that's appropriately licensed.
> > 
> > Andreas, you did the work to replace iniparser here:
> > 
> > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/config_parser
> > 
> > with your config parser code instead.
> 
> Feel free to rebase it. The code is from libssh, but it works a bit different 
> there.
> 
> http://git.libssh.org/projects/libssh.git/tree/src/config.c
> 
> 
> I think Jelmer objected to it lately and said we should use the ini parsing 
> code from param.
Yes, I think we should reuse existing code in the tree rather than
adding more ini implementations that we have to maintain. :-)

Jeremy pointed out though that the existing code is GPL though, while
this needs to be LGPL.

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - https://jelmer.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140810/a7a3e1c1/attachment.pgp>