[PATCH] Fix an error path memleak

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat Aug 9 12:59:52 MDT 2014


On Sat, Aug 09, 2014 at 05:23:54PM +0000, jim wrote:
> Free should be after DEBUG.

Thanks! :-))

Fixed patch attached.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 6747c946502ae85968a7e2414fbc69cff8583459 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Sat, 9 Aug 2014 16:51:05 +0000
Subject: [PATCH] messaging3: Fix an error path memleak

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/lib/messages_dgm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/source3/lib/messages_dgm.c b/source3/lib/messages_dgm.c
index 8b897f6..df34d53 100644
--- a/source3/lib/messages_dgm.c
+++ b/source3/lib/messages_dgm.c
@@ -388,6 +388,7 @@ int messaging_dgm_cleanup(struct messaging_context *msg_ctx, pid_t pid)
 		ret = errno;
 		DEBUG(10, ("%s: open(%s) failed: %s\n", __func__,
 			   lockfile_name, strerror(ret)));
+		TALLOC_FREE(lockfile_name);
 		return ret;
 	}
 
-- 
1.8.1.2



More information about the samba-technical mailing list