[PATCH v2 0/9] printing: improve printcap update CPU usage

Andreas Schneider asn at samba.org
Fri Aug 8 01:26:59 MDT 2014

On Thursday 07 August 2014 17:40:31 David Disseldorp wrote:
> This patch-set attempts to address bug 10652: Samba consumes a lot of
> CPU when re-reading printcap info.
> It does so with the following changes to the printcap update procedure:
> - Use traverse_read for printer list share updates, instead of exclusive
>   (write locked) traversals. This significantly reduces printer_list.tdb
>   lock contention.
> - As suggested by Volker, reload per-client smbd printer share
>   inventories when needed, rather than immediately after every printer
>   list update.
>   - If the printer list has not changed since the previous reload, then
>     skip the printer share inventory update.
> - Split delete_and_reload_printers() functionality into two functions
>   such that per-client smbd processes do not perform registry.tdb
>   updates or printer unpublishing. This is now only performed by the
>   single process that performs the printer list update.
> Feedback appreciated.

Great work! Thanks for working on that.

Pushed to autobuild.

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list