[PATCH] libcli: Overwrite destination in cli_smb2_rename

Jeremy Allison jra at samba.org
Thu Aug 7 11:24:57 MDT 2014

On Wed, Aug 06, 2014 at 08:52:20AM +0200, Stefan (metze) Metzmacher wrote:
> I'd add a new function or an additional argument
> and let the caller decide.

Yeah, my test patch adds an additional arg, but
I'm leaning towards a new function cli_rename_overwrite()
instead (I know how much Volker hates arbitrary bool
args :-).

However, Win7 might not support trans2-pathname-based-SMB1
rename (lazy bastards :-), so this might have to get
re-written internally to use open/rename/close as the
SMB2 code does.

> The code in smbclient cmd_rename() should continue to return an error.

Yep - I already decided not to make changes to
smbclient semantics :-).


More information about the samba-technical mailing list