[Samba] [PATCH] samba-tool syntax error?

David Disseldorp ddiss at suse.de
Tue Aug 5 17:27:47 MDT 2014

Hi Marc,

On Tue, 05 Aug 2014 20:44:16 +0200
Marc Muehlfeld <mmuehlfeld at samba.org> wrote:

> # samba-tool user add demoB demopass --userou='ou=testOU'
> --given-name=new --surname=user  --gecos=198
> --mail-address=newuser at myschool.edu
> User 'demoB' created successfully
> Attached a small patch, that hopefully makes the example in the help a
> bit clearer. Please review and push, if it's OK.

Thanks for the patch!
The change looks okay, but I have a few minor comments:
- please add your Signed-off-by tag
- the option help text change in the second hunk doesn't quite make
  sense to me, as it refers to Example3. I'd prefer to just see single
  quotes added around CN=Users instead.

Cheers, David

More information about the samba-technical mailing list