[PATCH] libcli: Overwrite destination in cli_smb2_rename

Jeremy Allison jra at samba.org
Tue Aug 5 15:55:57 MDT 2014

On Tue, Aug 05, 2014 at 02:37:10PM -0700, Jeremy Allison wrote:
> However.... (email thinking in real-time here :-).
> have a client supplied replace_if_exists flag,
> the same as SMB2. So we could move to that
> instead.

So looks like we *can* do this. Now the
question is *how* should we do this.

We could create a cli_rename2() or
cli_rename_overwrite() which has the
desired semantics for both SMB1 and

Currently the code inside libsmbclient

       if (!NT_STATUS_IS_OK(cli_rename(targetcli1, targetpath1, targetpath2))) {
                int eno = SMBC_errno(ocontext, targetcli1);

                if (eno != EEXIST ||
                    !NT_STATUS_IS_OK(cli_unlink(targetcli1, targetpath2, FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_HIDDEN)) ||
                    !NT_STATUS_IS_OK(cli_rename(targetcli1, targetpath1, targetpath2))) {

so if it gets an EEXIST it falls back to
a non-atomic unlink and rename. So
chjanging this to remove the unlink
and just call cli_rename_overwrite()
directly would be a distinct improvement
without changing the underlying
semantics inside libsmbclient.

Thoughts ?


More information about the samba-technical mailing list