[PATCH] Fix bug 10716 - smbd constantly crashes when filename contains non-ascii character.
jra at samba.org
Tue Aug 5 10:01:39 MDT 2014
On Tue, Aug 05, 2014 at 11:28:25AM +0200, Volker Lendecke wrote:
> On Mon, Aug 04, 2014 at 11:20:38AM -0700, Jeremy Allison wrote:
> > Turns out that strcasecmp_m_handle()
> > and strncasecmp_m_handle() don't
> > handle conversion errors very well.
> > They skip over the non-converting
> > characters, which means they can
> > return a false match fore filenames
> > where the non-converting character
> > sequences occur at the end of the
> > string.
> > Fix confirmed by submitter.
> > Please review and push if happy !
> Pushed. Attached find a patch on top of this. Before I +1
> the bugzilla entry, I'd like you to comment on that one.
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de
> From 976f54f3607834040d6c1112cd1be6ae9d3019ac Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Tue, 5 Aug 2014 09:21:07 +0000
> Subject: [PATCH] lib: strings: Simplify strcasecmp
> This makes us fallback to strcasecmp early if any INVALID_CODEPOINT
> appears. Without this patch we just continue to compare if both strings
> happen to have an INVALID_CODEPOINT in the same spot.
Ooh! Very nice cleanup - I'll push on top with my 'Reviewed-by:'
Thanks for that one.
More information about the samba-technical