[PATCH] Fix bug 10716 - smbd constantly crashes when filename contains non-ascii character.

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Aug 5 05:27:37 MDT 2014


On Tue, Aug 05, 2014 at 11:28:25AM +0200, Volker Lendecke wrote:
> On Mon, Aug 04, 2014 at 11:20:38AM -0700, Jeremy Allison wrote:
> > Turns out that strcasecmp_m_handle()
> > and strncasecmp_m_handle() don't
> > handle conversion errors very well.
> > 
> > They skip over the non-converting
> > characters, which means they can
> > return a false match fore filenames
> > where the non-converting character
> > sequences occur at the end of the
> > string.
> > 
> > Fix confirmed by submitter.
> > 
> > Please review and push if happy !
> 
> Pushed. Attached find a patch on top of this. Before I +1
> the bugzilla entry, I'd like you to comment on that one.

Well, the autobuild crashes right now even for current
master. Maybe someone else has better autobuild-fu can try
with my r-b?

Sorry,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list