[PATCH 0/7] printing: improve printcap update CPU usage

David Disseldorp ddiss at suse.de
Mon Aug 4 16:45:36 MDT 2014

On Mon, 4 Aug 2014 15:31:55 -0700, Jeremy Allison wrote:

> While you are going around one more time on this, can you
> move the function delete_and_reload_printers_full() from
> source3/smbd/server_reload.c -> source3/printing/queue_process.c
> and make it static ? Also, if you could eliminate the duplicate
> definitions of snum_is_shared_printer() in source3/rpc_server/spoolss/srv_spoolss_nt.c
> and in source3/smbd/server_reload.c that would be great also :-).

Sure, I'll include these changes in the next round.

> Sorry for asking for more, but these extra things would
> really help clean up the printing code somewhat, and make
> it clearer what's being done in the background process.

No problem, thanks for the feedback Jeremy.

Cheers, David

More information about the samba-technical mailing list