[PATCH 0/7] printing: improve printcap update CPU usage

David Disseldorp ddiss at suse.de
Mon Aug 4 16:26:20 MDT 2014

On Mon,  4 Aug 2014 15:58:00 +0200, David Disseldorp wrote:

> This patch-set attempts to address bug 10652: Samba consumes a lot of
> CPU when re-reading printcap info.
> It does so with the following changes to the printcap update procedure:
> - Use traverse_read for printer list share updates, instead of exclusive
>   (write locked) traversals. This significantly reduces printer_list.tdb
>   lock contention.
> - As suggested by Volker, reload per-client smbd printer share
>   inventories on client enumeration, rather than immediately after every
>   printer list update.
>   - If enumeration is requested but the printer list has not changed,
>     then skip the printer share inventory update.

Looks like one further change is needed here to handle clients that do
not enumerate printers prior to open, such as cupsaddsmb.

Cheers, David

More information about the samba-technical mailing list