[PATCH] Fix bug 10716 - smbd constantly crashes when filename contains non-ascii character.

Jeremy Allison jra at samba.org
Mon Aug 4 14:40:19 MDT 2014

On Mon, Aug 04, 2014 at 11:20:38AM -0700, Jeremy Allison wrote:
> Turns out that strcasecmp_m_handle()
> and strncasecmp_m_handle() don't
> handle conversion errors very well.
> They skip over the non-converting
> characters, which means they can
> return a false match fore filenames
> where the non-converting character
> sequences occur at the end of the
> string.
> Fix confirmed by submitter.

And by me locally of course :-).

And because I really should be concentrating
on test-driven-development these days :-),
here is the patchset with an additional
test suite for TESTS=local.charset that
tests the changes to strcasecmp_m_handle().
and strncasecmp_m_handle().

Please review and push if happy !

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug-10716-master.patch
Type: text/x-diff
Size: 7680 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140804/60586f65/attachment.patch>

More information about the samba-technical mailing list