[PATCH] selftest: Reduce waiting time for nmbd!

[Michael Adam]

On 2014-07-25 at 16:48 +0200, Andreas Schneider wrote:
> On Wednesday 23 July 2014 15:09:20 Michael Adam wrote:
> > Hi!
> > 
> > two comments:
> > 
> > 1. nmblookup3 is binary-mapped to nmblookup,
> >    so these commands are executed and can fail.
> >    I guess we can remove the old name and use
> >    nmblookup, but that should be a separate patch,
> >    imho.
> > 
> > 2. Other than that it is a good thing to reduce
> >    the startup time for the environment.
> >    I just want to point out that the current checks
> >    don't only check whether nmblookup is running
> >    but that it answeres a couple of requests.
> >    And it may take nmbd a certain startup time
> >    to be able to answer these.
> > 
> >    So the patch does make a difference, but it may
> >    well be enought to test only one request successfully.
> >    But imho this change should be made more explicit in the
> >    commit message.
> 
> 
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/selftest
> 
> 
> Here is the same splitted in two patches with the additional queries still 
> being executed after the first one succeeded.

Thanks - pushed to autobuild.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140804/8169d4b7/attachment.pgp>