[PATCH] locks: rename file-private locks to "open file description locks"

Jeff Layton jlayton at redhat.com
Tue Apr 22 08:55:20 MDT 2014

On Tue, 22 Apr 2014 17:45:31 +0300
Boaz Harrosh <openosd at gmail.com> wrote:

> On 04/22/2014 03:23 PM, Jeff Layton wrote:
> <>
> > 
> > We're going to have to live with these for a long time, so it's
> > important that we be happy with the names before we're stuck with them.
> > The consensus on the lists so far is that they should be rechristened as
> > "open file description locks".
> > 
> I completely agree with the rename. (Though could you please post
> the rest of the rename patches for review)
> Just a very small nit. My native language is not English but I would
> rather you use "file-descriptor" (with an '-' as well) and not
> use "description" in the English name of the lock. This is
> because stated like that, "description" might refer to the
> locks and not to the file in the sentence. file-descriptor is
> more clear I think. (For me it was confusing at first before I realized
> what you meant)
> Just my $0.017
> Thanks

There's a big difference between the descriptor and the description.

The numerical value you get back from something like open() is a file
descriptor. The thing that that value points to internally in the
kernel is the file description. It's very important that we do not
conflate the two here as these locks are associated with the file
description and not the file descriptor.

The best way to illustrate this is the interaction with dup() -- see
the LWN article on these for a complete overview.

Jeff Layton <jlayton at redhat.com>

More information about the samba-technical mailing list