[PATCH] Use idmap cache for all pdb backends.

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Apr 30 07:51:03 MDT 2014

On Wed, Apr 30, 2014 at 03:16:45PM +0200, Alexander Werth wrote:
> Currently only the passdb ldapsam backend uses the idmap cache.
> And even that only uses the cache when the option ldapsam:trusted is set.
> By moving the set cache entry calls up one layer all passdb backends
> will use the idmap cache.
> Without the idmap cache any id<->sid mapping request from ACLs for
> example would result in another set of ldap queries. Up to the point
> where the LDAP would be overloaded.

Looks good to me, thanks. When compiling I now get

[2299/4156] Compiling source3/passdb/pdb_ldap.c
../source3/passdb/pdb_ldap.c: In function ‘ldapsam_uid_to_sid’:
../source3/passdb/pdb_ldap.c:5014:16: warning: variable ‘id’ set but not used [-Wunused-but-set-variable]
../source3/passdb/pdb_ldap.c: In function ‘ldapsam_gid_to_sid’:
../source3/passdb/pdb_ldap.c:5087:16: warning: variable ‘id’ set but not used [-Wunused-but-set-variable]

It looks that if the "id" variable can be removed in both
cases. Do you want me to do this, or do you want to send a
new patch?



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list