Volker.Lendecke at SerNet.DE
Wed Apr 30 07:13:11 MDT 2014
On Tue, Apr 29, 2014 at 10:02:05PM -0700, Jeremy Allison wrote:
> On Tue, Apr 29, 2014 at 05:03:22PM +0200, Volker Lendecke wrote:
> > Hi!
> > Attached find a few patches for messaging3, one critical
> > bugfix (I believe). Right now autobuild is pretty flaky for
> > me, so I could not successfully run this through autobuild
> > yet. It does survive some simple tests for me though.
> > Posting it here for preliminary review, we need to wait I
> > guess until sn-devel settles down a bit again.
> OK, here is a 'Reviewed-by: <jra at samba.org>' version
> of the patchset that now passes samba3.raw.mux tests.
> The first patch is the fix for the wildcard unlink
> bug, so Volker or Michael if you could review that
> I'd appreciate it (it's a pretty obvious bugfix)
> so I can push it all in one go.
> Volker, the rest of it is your patchset with one
> minor change to fix the re-ordering of messages
> that caused the test to fail - in messaging_dispatch_rec()
> when req == NULL you swapped the end pointer with
> the NULL pointer in the array - this is the
> re-ordering that caused the samba3.raw.mux test
> to fail. I replaced it with a memmove which
> is less efficient but preserves the ordering
> of the message responses. Here is the change
> on top of your patchset:
Hmmm. Sorry for making you spend a day on an unfinished
patch. Thanks for all that work! Pushed to autobuild.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical