Volker.Lendecke at SerNet.DE
Tue Apr 29 14:13:36 MDT 2014
On Tue, Apr 29, 2014 at 12:58:51PM -0700, Jeremy Allison wrote:
> Then I finally realized that calling messaging_read_done()
> in the first pass could also modify waiters and num_waiters
> if the callback function called messaging_read_send(), so
> the staging array is the only safe way to do this.
Yep. It also took me several rounds and several iterations
of those tests to really catch this.
Thanks for going through this carefully!
By the way, I'm pretty sure we have a similar problem with
the normal messaging_register style callbacks. The main
difference is that those normal callbacks don't do any nasty
things that are possible and easier with tevent_req...
... Things you find when you really start playing with
> Phew.... :-).
> Gonna try pushing to autobuild. Wish me luck ! :-).
As I wrote: Normally I would only ask for pushing for such an
infrastructure patch if I had run it successfully through a
private autobuild. But it failed today always in the
delay_write or other timing-sensitive tests that I believe
have nothing to do with messaging.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical