[PATCH] Remove talloc_reference of event context in samba_dsdb stack and smb_krb5_init_context

Jeremy Allison jra at samba.org
Sun Apr 27 15:56:57 MDT 2014

On Mon, Apr 28, 2014 at 09:52:16AM +1200, Andrew Bartlett wrote:
> On Thu, 2014-04-17 at 22:52 +1200, Andrew Bartlett wrote:
> > Given the Team's dislike for both nested event loops and
> > talloc_reference, it seems fitting that my 'modest proposal' for
> > limiting one gives the opportunity to find and remove the the latter.
> > 
> > This patch uses the fact that the dsdb modules do not need to talk over
> > the network, so no event context need be specified or handled over to
> > talloc_reference, based on the messages my test of the patch in
> > https://lists.samba.org/archive/samba-technical/2014-April/099184.html 
> > 
> > Then I follow up by removing the parameter entirely, as it just isn't
> > needed.
> > 
> > Please review/push
> Can I please have a review/push of this?

I was planning to +1 this on Monday,
but I might not have chance (Bradley
arrives and I have to host).

Feel free to add my 'Reviewed-by' and
self-push if you're happy !


More information about the samba-technical mailing list