smbd as a daemon

Alexander Bokovoy ab at samba.org
Tue Apr 22 00:13:46 MDT 2014


On Tue, Apr 22, 2014 at 1:17 AM, Jeremy Allison <jra at samba.org> wrote:
> On Tue, Apr 08, 2014 at 06:51:45AM +0300, Alexander Bokovoy wrote:
>> On Wed, Mar 26, 2014 at 3:47 PM, Alexander Bokovoy <ab at samba.org> wrote:
>> > I've created bug 10517. The bug now has all patches for master and 4.1.
>> >
>> > https://bugzilla.samba.org/show_bug.cgi?id=10517
>>
>> Jeremy, ping, patches are waiting for you in the bug 10517.
>
> Ok, finally got off my ass and took a look at
> these.
>
> They're really nice (good job ! - even though I wanted
> to hate them because of systemd :-). Just one question.
>
> They change the error returns from the daemons from
> always (1) to a range of errno values. This seems to
> be to be the correct thing to do, but I still fear
> external dependencies on the error return... :-(.
>
> Alexander, presuade me it's ok, and I'll push
> the changes :-) :-).
(pasting the same anwer as in bugzilla):
Although we never defined or documented our exit behavior explicitly,
a convention was
that anything non-zero is error. I've checked some older documentation
and init scripts
and everywhere we have

  $RETVAL -eq 0

condition (or inverse of that).

-- 
/ Alexander Bokovoy


More information about the samba-technical mailing list