[PATCH] We should return WERR_BADFILE in _srvsvc_NetShareAdd if the path does not exist

David Disseldorp ddiss at suse.de
Mon Apr 21 16:58:13 MDT 2014


On Mon, 21 Apr 2014 15:49:30 -0700, Jeremy Allison wrote:

> > Any reason for bypassing the VFS here? Otherwise the patch looks okay.  
> 
> There is no share to use to go through the VFS - it
> is a request to create one.
> 
> This is the client sending a raw file system
> path to set up as a share.

Yeah chicken and egg I guess, as the share should be there after the
call, but needs to be validated beforehand... sorry for the noise.

David


More information about the samba-technical mailing list