[PATCH] Unix datagram socket messaging

[Michael Adam]

Jeremy,

please consider your 3 additional patches Reviewed-by: /me

Cheers - Michael


On 2014-04-18 at 15:47 -0700, Jeremy Allison wrote:
> On Fri, Apr 18, 2014 at 03:34:14PM -0700, Jeremy Allison wrote:
> > On Wed, Apr 16, 2014 at 12:00:04PM +0200, Stefan (metze) Metzmacher wrote:
> > > 
> > > Can we pass tevent_context to poll_funcs_init_tevent() instead of
> > > using: func.private_data = ev; in the caller?
> > 
> > Done.
> > 
> > > There're environments with just winbindd running, so we might need a
> > > periodic
> > > cleanup run not only in smbd.
> > 
> > Refactored so cleanup is run in nmbd and winbindd also.
> > 
> > > I think we should cast with (struct sockaddr *)(void *)&addr, in order
> > > to avoid
> > > strict aliasing warnings on some systems.
> > 
> > Done.
> > 
> > > After socket() we should set FD_CLOEXEC and O_NONBLOCK similar to
> > > tsocket_bsd_common_prepare_fd() or set_blocking() and
> > > smb_set_close_on_exec().
> > > MSG_DONTWAIT might not be available everywhere.
> > 
> > Done.
> > 
> > > may need some more magic and also check for EAGAIN,
> > > see tsocket_bsd_error_from_errno() or commit
> > > f5a3d74264abb25009e73b1b35d62db34fa62343.
> > > ... ok, I just found that it's fixed in
> > > https://git.samba.org/?p=vl/samba.git/.git;a=commitdiff;h=325e62cbb116abdec7cf1466862bd12ecd42224e
> > > I think we should squash that and also this one
> > > https://git.samba.org/?p=vl/samba.git/.git;a=commitdiff;h=d44c82a1edddb0d838702e15e00538faae9386bc
> > 
> > Done.
> > 
> > > + unlink(ctx->path);
> > > 
> > > We may need to check that ctx->path is not an empty string?
> > 
> > I altered it so ctx->path can never be invalid
> > (returns EINVAL) on path==NULL.
> > 
> > Here is the latest full patchset updated with all
> > these changes. Compiles and I'm now running
> > through make test to ensure it's all OK.
> > 
> > I'll follow up to get this in once it passes
> > make tests on Monday ! Just wanted you and
> > Volker to see where I'd gotten with it.
> 
> Pah! Sent the wip version with incorrect
> patches squashed instead :-(.
> 
> Here is the correct one, sorry.
> 
> Jeremy.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140419/fa019fb0/attachment.pgp>