[PATCH] Use common routines to interface to libwbclient auth
jra at samba.org
Thu Apr 17 10:42:58 MDT 2014
On Mon, Apr 14, 2014 at 04:00:10PM +1200, Andrew Bartlett wrote:
> On Wed, 2014-04-09 at 12:39 -0700, Jeremy Allison wrote:
> > On Wed, Apr 09, 2014 at 03:26:04PM +1200, Andrew Bartlett wrote:
> > > This patch makes the code to convert from an 'info3' as exposed by
> > > libwbclient common. This is not yet used in any useful way (and may not
> > > be the long-term way we integrate with winbindd due to async issues),
> > > but it seems poor to keep a known-wrong set of the code around when we
> > > can just re-use the working code.
> > >
> > > Please review/push.
> > Needs a NULL check in the second patch.
> > You have:
> > -----------------------------------------------------
> > @@ -303,11 +222,11 @@ static NTSTATUS winbind_check_password_wbclient(struct auth_method_context *ctx,
> > wbc_status, wbcErrorString(wbc_status)));
> > return NT_STATUS_LOGON_FAILURE;
> > }
> > - nt_status = get_info3_from_wbcAuthUserInfo(mem_ctx, info, &info3);
> > + info3 = wbcAuthUserInfo_to_netr_SamInfo3(mem_ctx, info);
> > wbcFreeMemory(info);
> > NT_STATUS_NOT_OK_RETURN(nt_status);
> > - validation.sam3 = &info3;
> > + validation.sam3 = info3;
> > nt_status = make_user_info_dc_netlogon_validation(mem_ctx,
> > user_info->client.account_name,
> > 3, &validation,
> Fixed patches attached.
I'll try and get to this today, tomorrow at
the latest ! Thanks for your patience.
More information about the samba-technical