[PATCH] Remove talloc_reference of event context in samba_dsdb stack and smb_krb5_init_context

Andrew Bartlett abartlet at samba.org
Thu Apr 17 04:52:36 MDT 2014

Given the Team's dislike for both nested event loops and
talloc_reference, it seems fitting that my 'modest proposal' for
limiting one gives the opportunity to find and remove the the latter.

This patch uses the fact that the dsdb modules do not need to talk over
the network, so no event context need be specified or handled over to
talloc_reference, based on the messages my test of the patch in

Then I follow up by removing the parameter entirely, as it just isn't

Please review/push

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-Specify-no-event-context-to-smb_krb5_init_conte.patch
Type: text/x-patch
Size: 2831 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140417/1cbe32b4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-kerberos-Remove-un-used-event-context-argument-from-.patch
Type: text/x-patch
Size: 8681 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140417/1cbe32b4/attachment-0001.bin>

More information about the samba-technical mailing list