[PATCH] Unix datagram socket messaging
jra at samba.org
Wed Apr 16 10:41:29 MDT 2014
On Wed, Apr 16, 2014 at 12:55:54PM +0200, Stefan (metze) Metzmacher wrote:
> No, it's fine, then just leave it as static copy.
> While it's not strictly needed and I agree that there's no need to
> push the more or less independent patches before they're really needed.
> I'd like to have them as first patches in the patchset, this way
> each commit would be able to pass make test (in theory, I don't want you
> to prove
> that :-).
Yes, but you don't *need* this to mark the code good, do you :-).
> Ok, just leave it as it is for now, we would be able to change it later
> if it's really a problem.
> I don't think so 'struct sockaddr' is too small, as far
> as I can tell this is the only way to avoid this warnings,
> other than defining a union, which would be overkill for this case.
So, once we're OK on the sockaddr issue, and I've finished
my review I'm planning to push Volker's code, 'cos it's a significant
improvement on what we already have !
Then we should work on replacing the source4/ messaging code
with this, so we're using a common messaging core (but that's
code for another day :-).
More information about the samba-technical