[PATCHSET] cwrap for 'make test'
Stefan (metze) Metzmacher
metze at samba.org
Wed Apr 16 07:03:42 MDT 2014
I think I finally finished my review of this.
Please have a look at
>> I'm finally done with migrating our source tree to use the preloadable
>> wrappers. I check if a system version of the wrappers is installed and
>> available with the needed version. If none is installed it will use the
>> bundled version.
>> What are the advantages of the preloadable version?
>> * You can run 'make test' with a optimized build.
>> * It works with each system library and binary.
>> * We can use external projects in future (MIT KDC)
>> You can find the patchset here:
>> I'm looking forward to discuss the patches with you!
> One issue I raised last time that is un-addressed is the change to the
> ldb module code, which worked around issues with samba_dlz.so being
> linked against internal Heimdal, and BIND9 itself being linked against
> the system MIT.
> I understand (but do not agree with) your position that having both in
> the same binary is a problem, but this is essentially what every single
> Samba installation using BIND9 does, and does sucessfully, and we can't
> break it.
Sure, but is this really a problem anymore, as we have symbol versioning?
For now we use just disable RTLD_DEEPBIND during make test,
but don't the default for now:
I'm currently doing some private autobuilds with this branch.
If won't be new problems, I'd push this tomorrow if nobody objects.
More information about the samba-technical