rb at sernet.de
Fri Apr 11 05:59:30 MDT 2014
On Thu, Apr 10, 2014 at 10:29:58AM -0700, Jeremy Allison wrote:
> On Thu, Apr 10, 2014 at 07:18:57PM +0200, Ralph Böhme wrote:
> > So the nice thing is, it's all text. The bad thing is, ...
> > > Is it at all documented?
> > ...it's completey undocumented. :)
> Haha. Why am I 'not at all surprised' :-).
Hopefully now that I'm pulling that beast into the bright light out of
the dark corner it used to hide, someone somewhere changes this. :)
> Still - this looks like fantastic work !
> > > I'll take a closer look in the coming days. Just a comment from
> > > skimming through: please avoid the macros added with
> > > https://github.com/slowfranklin/samba/commit/49d75640a2c58f8c6b0a00aae6920be9f38c6678
> > >
> > > They're generally frowned upon, as they affect control-flow (by jumping
> > > a magic label), and also rely on externally defined variables.
> > they're actually local variables and imo well defined and consistent
> > error checking is the best thing since sliced break. :)
> True. But control-flow-macros are the devils own tool :-).
> > Anyway, I'm
> > not eager to introduce this idiom and can exchange that for explicit
> > gotos.
> Thanks ! Please don't use control-flow-macros in new code !
Removed in a73fdd5e69fd5659193eb02b0cd2059902338211, RIP. :)
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical