More recvfile optimizations

Stefan (metze) Metzmacher metze at
Thu Apr 10 17:48:27 MDT 2014

Am 10.04.2014 23:58, schrieb Stefan (metze) Metzmacher:
> Am 10.04.2014 23:24, schrieb Jeremy Allison:
>> On Thu, Apr 10, 2014 at 11:05:14PM +0200, Stefan (metze) Metzmacher wrote:
>>> I don't have a fix.
>>> But we would need such check in is_smb2_recvfile_write(), correct?
>> Well, there are two ways of doing it.
>> First one is to add the :
>> smbd_smb2_request_check_session()
>> smbd_smb2_request_check_tcon()
>> calls into is_smb2_recvfile_write(), which is
>> the same way the SMB1 code does it.
> I'd just do a smb2srv_open_lookup() to get fsp
> (similar to file_fsp_get()), and use fsp->conn.
> In future I'd let is_valid_writeX_buffer()
> use smb1srv_open_lookup() instead of smb1srv_tcon_lookup().

Ok, here's my first set which doesn't add fsp->supports_recvfile yet.

Jones, can you do some iometer testing with this on top of master?

It would also be good to have iometer result for max protocol = NT1
comparing (maybe v3-6-test,) v4-0-test, v4-1-test and master.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-diff
Size: 16717 bytes
Desc: not available
URL: <>

More information about the samba-technical mailing list