[PATCH] Fix extra_data length in new async winbind idmap code

[Andrew Bartlett]

On Mon, 2014-04-07 at 12:01 +0200, David Disseldorp wrote:
> On Mon, 07 Apr 2014 14:14:04 +1200, Andrew Bartlett wrote:
> 
> > I found this when trying to use winbindd in the AD DC.
> > 
> > Please review/push. 
> 
> Would have preferred some extra parentheses, but looks good as is:
> Reviewed-by: David Disseldorp <ddiss at samba.org>
> 
> Please add your sign-off and push.

I've now found the cause of the error, and the patch is attached.

However, what I would like is a review and comment regarding the degree
of pointer manipulation in wbc_sids_to_xids().  It is, I agree, very
efficient code, and is now correct as far as I can see.  However, it
also feels like the kind of 'just a bit too tricky' code that shouldn't
be used except in hot paths with little or no other options.

What do you think?

https://git.samba.org/samba.git/?p=samba.git;a=blob;f=source4/libcli/wbclient/wbclient.c;h=b5183be121b409d228b25e9aff535e3d6d4c578e;hb=HEAD#l127?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-wbclient-Fix-wbc_sids_to_xids-to-correctly-indica.patch
Type: text/x-patch
Size: 1213 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140409/e8256e9e/attachment.bin>