[PATCH] Fix bug 9412 - SMB2 server doesn't support recvfile.

Jeremy Allison jra at samba.org
Tue Apr 8 18:02:39 MDT 2014


On Mon, Apr 07, 2014 at 03:24:15PM -0700, Jeremy Allison wrote:
> On Mon, Apr 07, 2014 at 06:43:35PM +0800, Jones wrote:
> > 2014-04-03 18:11 GMT+08:00 Jones <jones.kstw at gmail.com>:
> > 
> >           2014-04-03 2:06 GMT+08:00 Stefan (metze)
> >           Metzmacher <metze at samba.org>:
> > 
> >           And turn the socket into blocking mode once we get EAGAIN?
> > 
> >      Add poll_one_fd() and infinite waiting for socket fd is ready to
> >      read.
> > 
> > 
> > Hello Jeremy, Metze,
> > 
> > After lookup the BUGS section in man page select/poll,
> > it seems not a good idea to select/poll a fd with O_NONBLOCK,
> > my modification may cause undefined behavior which is platform dependent.
> > 
> > After checking sys_sendfile(),
> > a preliminary thought prompt to handle the EAGAIN in sys_recvfile(),
> > please kindly help comment,
> > thanks.
> 
> Jones, can you test the following ?
> 
> If it works for you in reducing CPU usage
> I'll add your name to it and propose it
> for mater.

Ping - Jones ! Did you get the chance
to test this ? Is should reduce the number
of blocking/unblocking calls you see in
this case when the client is streaming
writes to the server.

Jeremy.


More information about the samba-technical mailing list