[PATCH] s3-lib/util: fix read across end of namelist string

Jeremy Allison jra at samba.org
Tue Apr 8 11:26:25 MDT 2014


On Tue, Apr 08, 2014 at 10:25:40AM +0200, Bjoern Baumbach wrote:
> Hi!
> 
> If the namelist, which set_namearray receives, is not terminated with a
>  '/', we try to read the next character behind the string termination '\0'.
> In the case that the namelist is followed by a (more or less) valid
> string, we could produce several effects like unintentional vetoed,
> hidden or non-oplocked files or failures like:
> "Conversion error: Incomplete multibyte sequence(..."
> 
> Please find attached the proposed patch :-)

Reviewed-and-pushed. Congratulations - that
was a *GREAT* catch ! Thanks a lot Bjoern.

Jeremy.


More information about the samba-technical mailing list