[PATCH] pkgconfig: @LIB_RPATH@ should be in link flags
Stefan (metze) Metzmacher
metze at samba.org
Fri Apr 4 04:17:19 MDT 2014
Hi Lukas,
can you please split the commit into two commits?
Then it's fine for me.
Thanks!
metze
>> After exapnding, @LIB_RPATH@ will be -Wl,-rpatch,/usr/local/lib if rpath is
>> used on install. But "-Wl," will be passed to linker and should not be among
>> CFLAGS. Other pkgconfig files have @LIB_RPATH@ in the right place.
>> @see commit 735c1cd2da15167748e92ba6de48fdb5169db587
>>
>> Simple patch is attached.
>>
>> LS
>
> Is there any voluteer to review patch?
>
> It isn't very nice if you can see a lot of warnings.
>
> CC src/util/child_common.lo
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
> CC src/util/util.lo
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
> CC src/util/memory.lo
> CC src/util/server.lo
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
> CC src/util/signal.lo
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
> CC src/util/usertools.lo
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
> CC src/util/backup_file.lo
> cc: warning: -Wl,-rpath,/usr/local/lib: 'linker' input unused
>
> sh-4.2$ pkg-config --cflags tevent
> -Wl,-rpath,/usr/local/lib -I/usr/local/include
>
> sh-4.2$ pkg-config --cflags talloc
> -I/usr/local/include
>
> LS
>
More information about the samba-technical
mailing list