[PATCHES] Cleanup dead records in messages.tdb
Jeremy Allison
jra at samba.org
Wed Apr 2 18:09:13 MDT 2014
On Wed, Apr 02, 2014 at 05:04:07PM -0700, Christof Schmitt wrote:
>
> I did not have much time today to follow-up on this. My thought was that
> the messages.tdb is a local file, never managed by ctdb and it should be
> small, so that traversals should only have a small impact. The advantage
> of the traversal would be that it also catches stale records that for
> some reason have not been cleaned up previously.
>
> That said, i also see Volker's point that dead records in messages.tdb
> should only result from unclean exits, and we can just remove the PID
> from messages.tdb that just exited. That call could be added to
> remove_child_pid().
>
> I will rewrite the patch later this week.
I already did :-). If you want to review and add
your 'Signed-off-by:' I'm happy with that as
it was based on your ideas !
Cheers,
Jeremy
More information about the samba-technical
mailing list