[PATCHES] Cleanup dead records in messages.tdb

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Apr 2 14:02:34 MDT 2014

On Wed, Apr 02, 2014 at 10:20:15AM -0700, Jeremy Allison wrote:
> > Can we avoid the traverse in the normal case? Is it really
> > that the smbds in your case left corrupt keys behind? In
> > remove_child_pid we know which child died, so we could
> > directly check and delete its record. Traverses always scare
> > me :-)
> We could always add a new message MSG_SMB_MSG_VALIDATE
> and have it act the same as MSG_SMB_BRL_VALIDATE does in
> cleaning up the brl lock db. That way we only traverse
> in the 'known child fail' case.

The point is -- I want to avoid the traverse. I wanted to
know from Christof whether there was more damage than just
orphaned records. Those could be cleaned up in a more
straightforward manner, avoiding traverse completely.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list