[PATCH] tdb: recycle dead records always at chain top

Michael Adam obnox at samba.org
Wed Apr 2 07:10:20 MDT 2014


On 2014-04-02 at 14:49 +0200, Volker Lendecke wrote:
> On Tue, Apr 01, 2014 at 01:49:45PM +0200, Michael Adam wrote:
> > 
> > ...
> > This may give an advantage when trying to find the record
> > again soon, but a disadvantage are the two
> > additional tdb_ofs_write calls.
> > 
> > Thoughts?
> 
> That looks good to me. 13 insertions(+), 43 deletions(-)
> should be argument enough, and I believe that a
> DLIST_PROMOTE outweighs the tdb_write_ofs calls, although I
> also think this will completely be hidden in noise.
> 
> Reviewed-by: Volker Lendecke <vl at samba.org>

Thanks.

> But please give it a bit before pushing, maybe others have
> other opinions here.

Sure. Will do.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140402/178ce17a/attachment.pgp>


More information about the samba-technical mailing list