[PATCHES] Cleanup dead records in messages.tdb

[Volker Lendecke]

On Tue, Apr 01, 2014 at 01:49:13PM -0700, Christof Schmitt wrote:
> When a smbd process dies, pending messages.tdb records for this process
> will not get cleaned up. I have seen one case where the messages.tdb
> file grew very large after I/O requests were delayed and smbd child
> processes died.
> 
> These patches implement cleanup of messages.tdb records that is
> triggered after a smbd dies; any record with an invalid key or a
> non-existing PID will get deleted.

Can we avoid the traverse in the normal case? Is it really
that the smbds in your case left corrupt keys behind? In
remove_child_pid we know which child died, so we could
directly check and delete its record. Traverses always scare
me :-)

With best regards,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de