Init functions in winbind idmap modules

Jeremy Allison jra at
Tue Apr 1 14:25:49 MDT 2014

On Tue, Apr 01, 2014 at 11:39:39AM -0700, Christof Schmitt wrote:
> The init functions in the winbind idmap modules are not very consistent,
> some are called samba_init_module, others use different names:
> source3/winbindd/idmap_ad.c:NTSTATUS samba_init_module(void)
> source3/winbindd/idmap_autorid.c:NTSTATUS samba_init_module(void)
> source3/winbindd/idmap_ldap.c:NTSTATUS idmap_ldap_init(void)
> source3/winbindd/idmap_nss.c:NTSTATUS idmap_nss_init(void)
> source3/winbindd/idmap_passdb.c:NTSTATUS idmap_passdb_init(void)
> source3/winbindd/idmap_rfc2307.c:NTSTATUS idmap_rfc2307_init(void)
> source3/winbindd/idmap_rid.c:NTSTATUS samba_init_module(void)
> I also saw that there is some code in waf to create a define to
> samba_init_module, but i find that somewhat confusing.
> Should all modules use a similar init function name for consistency?

That would probably help. Send in a patch and I'll
review !


More information about the samba-technical mailing list