[PATCH 3/3] build: make wafsamba WORDS_BIGENDIAN test cross-compile friendly

Gustavo Zacarias gustavo at zacarias.com.ar
Tue Apr 1 03:24:40 MDT 2014

On 03/31/2014 10:18 PM, Andrew Bartlett wrote:

> I would prefer you did as suggested, and unified the whole test.  In
> particular, coping over just the big-endian handling and assuming that
> this macro being absent is authoritative for little-endian seems
> dangerous, we should always do the fallback the ccan code does. 

Ok, i didn't know if it was ok to condense the whole endian test in
wafsamba (seemed the appropiate thing to do, reason why i mentioned it).
I think i'll keep the separate HAVE_X_ENDIAN and WORDS_BIGENDIAN
definitions separate though right?
Since it seems you're using foreign codebases and it's a oneliner to do
so rather than modifying them.

More information about the samba-technical mailing list